-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(index.html): use defer and move script to head #6999
Conversation
Current Playwright Test Results Summary✅ 153 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/09/2023 09:30:36pm UTC)
|
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
1.21% (2)2 / 165 runsfailed over last 7 days |
49.70% (82)82 / 165 runsflaked over last 7 days |
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
1.83% (3)3 / 164 runsfailed over last 7 days |
38.41% (63)63 / 164 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
3.55% (7)7 / 197 runsfailed over last 7 days |
53.81% (106)106 / 197 runsflaked over last 7 days |
📄 functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1 • Initial Attempt |
1.82% (3)3 / 165 runsfailed over last 7 days |
22.42% (37)37 / 165 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
0% (0)0 / 167 runsfailed over last 7 days |
69.46% (116)116 / 167 runsflaked over last 7 days |
This seems to be negatively impacting our e2e tests? Could you investigate? |
e2e ci doesnt seem related to this PR, could you re-run the job? Worst case can just close this PR, it's just nitpicks |
Codecov Report
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 56.08% 56.02% -0.06%
==========================================
Files 652 652
Lines 26178 26178
Branches 2525 2525
==========================================
- Hits 14682 14667 -15
- Misses 10795 10806 +11
- Partials 701 705 +4
*This pull request uses carry forward flags. Click here to find out more. see 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Status on this? |
Looks good so far as e2e and unit tests are passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Describe your changes:
Regular convention is having script in . Added defer for the script to run after page is loaded.
https://www.w3schools.com/tags/att_script_defer.asp
All Submissions:
Author Checklist
Reviewer Checklist