Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(index.html): use defer and move script to head #6999

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

evenstensberg
Copy link
Contributor

@evenstensberg evenstensberg commented Aug 27, 2023

Describe your changes:

Regular convention is having script in . Added defer for the script to run after page is loaded.

https://www.w3schools.com/tags/att_script_defer.asp

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Aug 27, 2023

Current Playwright Test Results Summary

✅ 153 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/09/2023 09:30:36pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 03e6e61

Started: 11/09/2023 09:23:47pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
1.21% (2) 2 / 165 runs
failed over last 7 days
49.70% (82) 82 / 165 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
1.83% (3) 3 / 164 runs
failed over last 7 days
38.41% (63) 63 / 164 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
3.55% (7) 7 / 197 runs
failed over last 7 days
53.81% (106) 106 / 197 runs
flaked over last 7 days

📄   functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1Initial Attempt
1.82% (3) 3 / 165 runs
failed over last 7 days
22.42% (37) 37 / 165 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
0% (0) 0 / 167 runs
failed over last 7 days
69.46% (116) 116 / 167 runs
flaked over last 7 days

View Detailed Build Results


@ozyx ozyx added source:community Community contribution or request pr:e2e:couchdb npm run test:e2e:couchdb labels Aug 28, 2023
@ozyx
Copy link
Contributor

ozyx commented Sep 1, 2023

This seems to be negatively impacting our e2e tests? Could you investigate?

@evenstensberg
Copy link
Contributor Author

e2e ci doesnt seem related to this PR, could you re-run the job? Worst case can just close this PR, it's just nitpicks

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #6999 (03e6e61) into master (591b574) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6999      +/-   ##
==========================================
- Coverage   56.08%   56.02%   -0.06%     
==========================================
  Files         652      652              
  Lines       26178    26178              
  Branches     2525     2525              
==========================================
- Hits        14682    14667      -15     
- Misses      10795    10806      +11     
- Partials      701      705       +4     
Flag Coverage Δ *Carryforward flag
e2e-full 41.79% <ø> (ø) Carriedforward from 591b574
e2e-stable 58.04% <ø> (-0.04%) ⬇️
unit 49.39% <ø> (-0.06%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 591b574...03e6e61. Read the comment docs.

@unlikelyzero unlikelyzero added this to the Target:3.1.0 milestone Sep 11, 2023
@akhenry akhenry modified the milestones: Target:3.1.0, 3.2.0 Oct 2, 2023
@unlikelyzero unlikelyzero removed this from the Target:3.2.0 milestone Oct 27, 2023
@evenstensberg
Copy link
Contributor Author

Status on this?

@ozyx
Copy link
Contributor

ozyx commented Nov 9, 2023

Status on this?

Looks good so far as e2e and unit tests are passing. Could you resolve the linting errors? Looks like this was resolved in master

@ozyx ozyx self-requested a review November 9, 2023 18:48
@ozyx ozyx added this to the Target:3.2.0 milestone Nov 9, 2023
@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb type:maintenance tests, chores, or project maintenance and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Nov 9, 2023
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ozyx ozyx modified the milestones: Target:3.2.0, Target:3.3.0 Nov 9, 2023
@ozyx ozyx merged commit 29b7c38 into nasa:master Nov 9, 2023
21 of 22 checks passed
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:3.2.0 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:e2e:couchdb npm run test:e2e:couchdb source:community Community contribution or request type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants