Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin vue package versions #7032

Merged
merged 2 commits into from
Sep 3, 2023
Merged

chore: pin vue package versions #7032

merged 2 commits into from
Sep 3, 2023

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Sep 1, 2023

Closes #7031

Describe your changes:

Pins Vue and related packages' versions so that dependabot can manage upgrades and to ensure a consistent version is installed.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Sep 1, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/03/2023 03:14:34pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 30c5e80

Started: 09/03/2023 03:12:44pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 8 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/03/2023 03:14:34pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 30c5e80

Started: 09/01/2023 11:44:55pm UTC

⚠️ Flakes

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 4 Flakes

Top 1 Common Error Messages

null

4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery in Display Layout View Large action pauses imagery when in realtime and returns to realtime
Retry 1Initial Attempt
0% (0) 0 / 99 runs
failed over last 7 days
8.08% (8) 8 / 99 runs
flaked over last 7 days
Example Imagery in Display Layout View Large action leaves keeps realtime mode paused
Retry 1Initial Attempt
0% (0) 0 / 99 runs
failed over last 7 days
4.04% (4) 4 / 99 runs
flaked over last 7 days
Example Imagery in Display Layout Resizing the layout changes thumbnail visibility and size
Retry 1Initial Attempt
0% (0) 0 / 99 runs
failed over last 7 days
8.08% (8) 8 / 99 runs
flaked over last 7 days
Example Imagery in Display Layout Toggle layer visibility by clicking on label
Retry 1Initial Attempt
1.02% (1) 1 / 98 run
failed over last 7 days
7.14% (7) 7 / 98 runs
flaked over last 7 days

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
2.06% (2) 2 / 97 runs
failed over last 7 days
39.18% (38) 38 / 97 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 97 runs
failed over last 7 days
59.79% (58) 58 / 97 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 97 runs
failed over last 7 days
51.55% (50) 50 / 97 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0.78% (1) 1 / 128 run
failed over last 7 days
48.44% (62) 62 / 128 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #7032 (30c5e80) into master (64740e1) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7032      +/-   ##
==========================================
- Coverage   48.33%   48.21%   -0.13%     
==========================================
  Files         643      643              
  Lines       25730    25730              
  Branches     2512     2512              
==========================================
- Hits        12436    12405      -31     
- Misses      12801    12844      +43     
+ Partials      493      481      -12     
Flag Coverage Δ *Carryforward flag
e2e-full 42.02% <ø> (ø) Carriedforward from 64740e1
e2e-stable 57.01% <ø> (+3.87%) ⬆️
unit 38.66% <ø> (-0.86%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 41 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64740e1...30c5e80. Read the comment docs.

@unlikelyzero unlikelyzero added this to the Target:3.1.0 milestone Sep 1, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 1, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 1, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 2, 2023
@ozyx ozyx enabled auto-merge (squash) September 2, 2023 01:09
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 2, 2023
@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 3, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 3, 2023
@ozyx ozyx merged commit e9b94c3 into master Sep 3, 2023
13 of 15 checks passed
@ozyx ozyx deleted the pin-vue-versions branch September 3, 2023 15:14
@shefalijoshi shefalijoshi added the type:maintenance tests, chores, or project maintenance label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin Vue package versions
3 participants