Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mojibake #7073

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Fix mojibake #7073

merged 2 commits into from
Sep 21, 2023

Conversation

akhenry
Copy link
Contributor

@akhenry akhenry commented Sep 20, 2023

Closes #5884

Describe your changes:

Modifies the build process to prepend the generated theme CSS files with explicit UTF-8 encoding. In testing this seems to fix the mojibake issue.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Sep 20, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/20/2023 08:36:31pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: cd56997

Started: 09/20/2023 08:29:50pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 139 Passing - ⚠️ 6 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/20/2023 08:36:31pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: cd56997

Started: 09/20/2023 08:28:32pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 114 runs
failed over last 7 days
43.86% (50) 50 / 114 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
1.75% (2) 2 / 114 runs
failed over last 7 days
36.84% (42) 42 / 114 runs
flaked over last 7 days

📄   functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1Initial Attempt
3.64% (4) 4 / 110 runs
failed over last 7 days
17.27% (19) 19 / 110 runs
flaked over last 7 days

📄   functional/plugins/plot/tagging.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Plot Tagging Tags work with Overlay Plots
Retry 2Retry 1Initial Attempt
33.33% (36) 36 / 108 runs
failed over last 7 days
15.74% (17) 17 / 108 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
1.37% (2) 2 / 146 runs
failed over last 7 days
49.32% (72) 72 / 146 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
1.82% (1) 1 / 55 run
failed over last 7 days
78.18% (43) 43 / 55 runs
flaked over last 7 days

View Detailed Build Results


@unlikelyzero unlikelyzero enabled auto-merge (squash) September 20, 2023 22:50
@unlikelyzero unlikelyzero added this to the Target:3.0.2 milestone Sep 20, 2023
@unlikelyzero unlikelyzero added the bug:regression It used to work. Now it doesn't :( label Sep 20, 2023
@unlikelyzero unlikelyzero merged commit 05c7a81 into master Sep 21, 2023
23 of 30 checks passed
@unlikelyzero unlikelyzero deleted the fix-mojibake branch September 21, 2023 01:01
@akhenry akhenry modified the milestones: Target:3.1.0, Target:3.0.2 Sep 21, 2023
akhenry added a commit that referenced this pull request Sep 21, 2023
Add charset preamble to generated css
unlikelyzero pushed a commit that referenced this pull request Sep 21, 2023
Fix mojibake (#7073)

Add charset preamble to generated css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mojibake instead of glyphs
2 participants