-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐
๐ฎโก Removeopenmct.components
โก๐ฎ๐
#7075
Conversation
Current Playwright Test Results Summaryโ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/21/2023 09:05:18pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 9fc5368 Started: 09/21/2023 08:59:30pm UTC Current Playwright Test Results Summaryโ
139 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/21/2023 09:05:18pm UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 โข Initial Attempt |
5.65% (7)7 / 124 runsfailed over last 7 days |
28.23% (35)35 / 124 runsflaked over last 7 days |
๐ ย functional/planning/timelist.e2e.spec.js โข 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 โข Initial Attempt |
1.28% (2)2 / 156 runsfailed over last 7 days |
50% (78)78 / 156 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #7075 +/- ##
==========================================
+ Coverage 53.36% 55.53% +2.17%
==========================================
Files 649 649
Lines 26055 26040 -15
Branches 2547 2547
==========================================
+ Hits 13903 14461 +558
+ Misses 11461 10877 -584
- Partials 691 702 +11
*This pull request uses carry forward flags. Click here to find out more.
... and 101 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
๐ ๐ฎโก`openmct.components`โก๐ฎ๐ Co-authored-by: Andrew Henry <[email protected]>
๐ ๐ฎโก`openmct.components`โก๐ฎ๐ Co-authored-by: Andrew Henry <[email protected]> Co-authored-by: Shefali Joshi <[email protected]>
Testing Instructions
|
Closes #7074
Describe your changes:
Removes the
components
property from the public API as it is no longer needed (see InspectorDataVisualization plugin) and was causing memory leaks to occur.All Submissions:
Author Checklist
Reviewer Checklist