Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ™…๐Ÿšฎโก Removeopenmct.components โก๐Ÿšฎ๐Ÿ™… #7075

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Sep 20, 2023

Closes #7074

Describe your changes:

Removes the components property from the public API as it is no longer needed (see InspectorDataVisualization plugin) and was causing memory leaks to occur.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx added this to the Target:3.0.2 milestone Sep 20, 2023
@ozyx ozyx requested a review from davetsay September 20, 2023 23:15
@deploysentinel
Copy link

deploysentinel bot commented Sep 20, 2023

Current Playwright Test Results Summary

โœ… 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/21/2023 09:05:18pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 9fc5368

Started: 09/21/2023 08:59:30pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

โœ… 139 Passing - โš ๏ธ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/21/2023 09:05:18pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 9fc5368

Started: 09/21/2023 08:58:25pm UTC

โš ๏ธ Flakes

๐Ÿ“„ ย  functional/plugins/plot/logPlot.e2e.spec.js โ€ข 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 โ€ข Initial Attempt
5.65% (7) 7 / 124 runs
failed over last 7 days
28.23% (35) 35 / 124 runs
flaked over last 7 days

๐Ÿ“„ ย  functional/planning/timelist.e2e.spec.js โ€ข 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 โ€ข Initial Attempt
1.28% (2) 2 / 156 runs
failed over last 7 days
50% (78) 78 / 156 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #7075 (bfc49a5) into master (482f1f6) will increase coverage by 2.17%.
The diff coverage is n/a.

โ— Current head bfc49a5 differs from pull request most recent head 9fc5368. Consider uploading reports for the commit 9fc5368 to get more accurate results

@@            Coverage Diff             @@
##           master    #7075      +/-   ##
==========================================
+ Coverage   53.36%   55.53%   +2.17%     
==========================================
  Files         649      649              
  Lines       26055    26040      -15     
  Branches     2547     2547              
==========================================
+ Hits        13903    14461     +558     
+ Misses      11461    10877     -584     
- Partials      691      702      +11     
Flag Coverage ฮ” *Carryforward flag
e2e-full 41.98% <รธ> (+0.06%) โฌ†๏ธ Carriedforward from 05c7a81
e2e-stable 57.35% <รธ> (+11.10%) โฌ†๏ธ
unit 49.07% <รธ> (+0.46%) โฌ†๏ธ

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage ฮ”
src/MCT.js 97.32% <รธ> (-0.03%) โฌ‡๏ธ

... and 101 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update 482f1f6...9fc5368. Read the comment docs.

@ozyx ozyx requested a review from akhenry September 21, 2023 16:42
@akhenry akhenry enabled auto-merge (squash) September 21, 2023 20:28
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 21, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 21, 2023
@akhenry akhenry merged commit ff2c8b3 into master Sep 21, 2023
6 of 7 checks passed
@akhenry akhenry deleted the mct7074 branch September 21, 2023 21:05
ozyx added a commit that referenced this pull request Sep 21, 2023
๐Ÿ™…๐Ÿšฎโก`openmct.components`โก๐Ÿšฎ๐Ÿ™…

Co-authored-by: Andrew Henry <[email protected]>
shefalijoshi added a commit that referenced this pull request Sep 21, 2023
๐Ÿ™…๐Ÿšฎโก`openmct.components`โก๐Ÿšฎ๐Ÿ™…

Co-authored-by: Andrew Henry <[email protected]>
Co-authored-by: Shefali Joshi <[email protected]>
@ozyx
Copy link
Contributor Author

ozyx commented Sep 22, 2023

Testing Instructions

  • Open console, enter in openmct.components
  • It should be undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memory leaks in data visualization
2 participants