Fix Notebook entry hover problem #7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Playwright Test Results Summary✅ 165 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/14/2023 02:38:49pm UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Tabs View Renders tabbed elements
Retry 1 • Initial Attempt |
0% (0)0 / 35 runsfailed over last 7 days |
17.14% (6)6 / 35 runsflaked over last 7 days |
📄 functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1 • Initial Attempt |
0% (0)0 / 36 runsfailed over last 7 days |
16.67% (6)6 / 36 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
6.67% (4)4 / 60 runsfailed over last 7 days |
60% (36)36 / 60 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 36 runsfailed over last 7 days |
41.67% (15)15 / 36 runsflaked over last 7 days |
scottbell
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Good stuff @charlesh88
Screen.Recording.2023-10-03.at.9.19.12.AM.mov
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7106 +/- ##
==========================================
+ Coverage 55.66% 55.97% +0.30%
==========================================
Files 655 654 -1
Lines 26316 26229 -87
Branches 2543 2528 -15
==========================================
+ Hits 14650 14681 +31
+ Misses 10961 10843 -118
Partials 705 705
*This pull request uses carry forward flags. Click here to find out more. see 35 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…ix-entry-hover-7105
unlikelyzero
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7105
:not(:focus)CSS check for hover.Closes
Describe your changes:
CSS was not being triggered on hover when the field was the focus - this was an artifact of a previous workflow when we were using contenteditable on a div. That check was removed, and the hover styling has been refined.
All Submissions:
Author Checklist
Reviewer Checklist