Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#7122): [Staleness] Fix issue with object view staleness styles not being res… #7123

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

khalidadil
Copy link
Contributor

Closes #6339

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

…et on clock change (#7122)

Add logic to un/re-subscribe when clock changes to object view
@khalidadil khalidadil changed the title [Staleness] Fix issue with object view staleness styles not being res… cherry-pick(#7122): [Staleness] Fix issue with object view staleness styles not being res… Oct 6, 2023
@deploysentinel
Copy link

deploysentinel bot commented Oct 6, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/06/2023 11:31:36pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 95b3db2

Started: 10/06/2023 11:25:58pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 141 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/06/2023 11:31:36pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 95b3db2

Started: 10/06/2023 11:25:18pm UTC

⚠️ Flakes

📄   functional/plugins/timeConductor/timeConductor.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time conductor operations validate start time does not exceeds end time
Retry 1Initial Attempt
0% (0) 0 / 99 runs
failed over last 7 days
2.02% (2) 2 / 99 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
1.48% (2) 2 / 135 runs
failed over last 7 days
53.33% (72) 72 / 135 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
9.57% (9) 9 / 94 runs
failed over last 7 days
42.55% (40) 40 / 94 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
15.53% (16) 16 / 103 runs
failed over last 7 days
50.49% (52) 52 / 103 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@jvigliotta jvigliotta merged commit e43ddf6 into release/3.1.0 Oct 6, 2023
17 checks passed
@jvigliotta jvigliotta deleted the bugfix/issue-6339-cherry-pick-2 branch October 6, 2023 23:37
@unlikelyzero unlikelyzero added this to the Target:3.1.0 milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants