Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: watch mode improvements #7326

Merged
merged 1 commit into from
Dec 28, 2023
Merged

chore: watch mode improvements #7326

merged 1 commit into from
Dec 28, 2023

Conversation

unlikelyzero
Copy link
Collaborator

Closes: #7323

Describe your changes:

  • Adds a watch mode config to specify hot module reloading and the ability to run visual tests

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Dec 27, 2023
@unlikelyzero unlikelyzero added this to the Target:3.3.0 milestone Dec 27, 2023
// @ts-check

// eslint-disable-next-line no-unused-vars
const { devices } = require('@playwright/test');

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable devices.
Copy link

deploysentinel bot commented Dec 27, 2023

Current Playwright Test Results Summary

✅ 166 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/27/2023 05:33:28pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 5bfb678

Started: 12/27/2023 05:28:44pm UTC

⚠️ Flakes

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 39 runs
failed over last 7 days
66.67% (26) 26 / 39 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 38 runs
failed over last 7 days
52.63% (20) 20 / 38 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 15 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/27/2023 05:33:28pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 5bfb678

Started: 12/27/2023 05:28:32pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1Initial Attempt
0% (0) 0 / 19 runs
failed over last 7 days
15.79% (3) 3 / 19 runs
flaked over last 7 days

View Detailed Build Results


Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (715a448) 56.02% compared to head (5bfb678) 61.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7326      +/-   ##
==========================================
+ Coverage   56.02%   61.02%   +4.99%     
==========================================
  Files         658      420     -238     
  Lines       26361    13039   -13322     
  Branches     2546        0    -2546     
==========================================
- Hits        14769     7957    -6812     
+ Misses      10893     5082    -5811     
+ Partials      699        0     -699     
Flag Coverage Δ
e2e-full 41.79% <ø> (ø)
e2e-stable 58.55% <ø> (+<0.01%) ⬆️
unit ?

see 382 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 715a448...5bfb678. Read the comment docs.

@unlikelyzero unlikelyzero merged commit 5af4913 into master Dec 28, 2023
27 of 30 checks passed
@unlikelyzero unlikelyzero deleted the watchmode branch December 28, 2023 05:48
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] Improve and document e2e watch mode
2 participants