Add right click actions on imagery to allow high resolution download #7371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Current Playwright Test Results Summary✅ 15 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 01/11/2024 06:50:43pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: a6bc087 Started: 01/11/2024 06:47:01pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
CouchDB Status Indicator with mocked responses @couchdb Shows red if not connected
Retry 1 • Initial Attempt |
6.67% (3)3 / 45 runsfailed over last 7 days |
20% (9)9 / 45 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 176 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 01/11/2024 06:50:43pm UTC)
⚠️ Flakes
📄 functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
0% (0)0 / 89 runsfailed over last 7 days |
29.21% (26)26 / 89 runsflaked over last 7 days |
📄 functional/plugins/conditionSet/conditionSet.e2e.spec.js • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Condition Set CRUD Operations on @localStorage Condition set object properties persist in main view and inspector @localStorage
Retry 1 • Initial Attempt |
2.44% (2)2 / 82 runsfailed over last 7 days |
18.29% (15)15 / 82 runsflaked over last 7 days |
|
Condition Set CRUD Operations on @localStorage condition set object can be modified on @localStorage
Retry 1 • Initial Attempt |
-21.54% (-14)-14 / 65 runsfailed over last 7 days |
21.54% (14)14 / 65 runsflaked over last 7 days |
|
Condition Set CRUD Operations on @localStorage condition set object can be deleted by Search Tree Actions menu on @localStorage
Retry 1 • Initial Attempt |
-21.54% (-14)-14 / 65 runsfailed over last 7 days |
21.54% (14)14 / 65 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt |
0% (0)0 / 71 runsfailed over last 7 days |
26.76% (19)19 / 71 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
5.06% (4)4 / 79 runsfailed over last 7 days |
53.16% (42)42 / 79 runsflaked over last 7 days |
📄 functional/plugins/timeConductor/timeConductor.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time conductor input fields real-time mode preserve offsets and url params when switching between fixed and real-time mode
Retry 1 • Initial Attempt |
0% (0)0 / 75 runsfailed over last 7 days |
2.67% (2)2 / 75 runsflaked over last 7 days |
📄 functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1 • Initial Attempt |
5.13% (4)4 / 78 runsfailed over last 7 days |
19.23% (15)15 / 78 runsflaked over last 7 days |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7371 +/- ##
==========================================
- Coverage 55.88% 55.83% -0.05%
==========================================
Files 657 659 +2
Lines 26198 26245 +47
Branches 2548 2549 +1
==========================================
+ Hits 14640 14654 +14
- Misses 10852 10884 +32
- Partials 706 707 +1
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shefalijoshi
approved these changes
Jan 11, 2024
|
Demo: Screen.Recording.2024-01-11.at.3.57.28.PM.mov |
|
The icons look good to me. Nice work! |
|
Looks great, thanks. |
michaelrogers
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7356
Describe your changes:
Add some actions ("Open in new tab" & "Save Image As") to the right context menu for the Image Viewer.
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist