-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use different root for renderWhenVisible
#7415
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7415 +/- ##
==========================================
+ Coverage 55.53% 55.62% +0.08%
==========================================
Files 668 668
Lines 26701 26704 +3
Branches 2585 2585
==========================================
+ Hits 14828 14853 +25
+ Misses 11159 11139 -20
+ Partials 714 712 -2
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how to fix, but I can still reliably reproduce the issue both in e2e test (by running it in a docker container w/ repeatEach: 10
), and manually. :/
renderWhenVisible
when the ObjectView
changesrenderWhenVisible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, let's just add some comments
Closes #7405
Describe your changes:
Using the viewport for the IntersectionObserver was causing timing issues when rendering objects on page load. As the application loads itself, the ObjectView can be rendered well off the page, causing the IntersectionObserver to state that the ObjectView is hidden. Strangely, this doesn't appear to be recoverable as I think we're becoming visible through an event that isn't listened to by the IntersectionObserver. Instead, we can use the Open MCT root element as the root object for the IntersectionObserver.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist