Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have countdowns in the Timelist use a - symbol #7452

Merged

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Feb 1, 2024

Closes #7450

Describe your changes:

Pretty simple fix to add a - for countdown Timelist entries.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@scottbell scottbell linked an issue Feb 1, 2024 that may be closed by this pull request
7 tasks
@scottbell scottbell added this to the Target:4.0.0 milestone Feb 1, 2024
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 1, 2024
@scottbell scottbell marked this pull request as ready for review February 1, 2024 13:30
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18e4b9d) 55.59% compared to head (135e714) 55.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7452      +/-   ##
==========================================
+ Coverage   55.59%   55.64%   +0.05%     
==========================================
  Files         668      668              
  Lines       26800    26800              
  Branches     2606     2606              
==========================================
+ Hits        14899    14913      +14     
+ Misses      11186    11171      -15     
- Partials      715      716       +1     
Flag Coverage Δ
e2e-full 49.01% <ø> (-0.01%) ⬇️
e2e-stable 59.35% <ø> (+0.24%) ⬆️
unit 48.59% <ø> (-0.01%) ⬇️
Files Coverage Δ
src/plugins/timelist/TimelistComponent.vue 56.81% <ø> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18e4b9d...135e714. Read the comment docs.

@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 1, 2024
@scottbell scottbell changed the title Have countdowns in the Timelist have a - symbol Have countdowns in the Timelist use a - symbol Feb 1, 2024
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 1, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 1, 2024
@davetsay davetsay added the pr:e2e:flakefinder Runs the tests 10 times label Feb 1, 2024
@github-actions github-actions bot removed the pr:e2e:flakefinder Runs the tests 10 times label Feb 2, 2024
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@scottbell scottbell merged commit 3cbaa7b into master Feb 2, 2024
28 of 29 checks passed
@scottbell scottbell deleted the 7450-time-list-compact-view-time-tofrom-always-shows-with-+ branch February 2, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time List compact view "Time To/From" always shows with "+"
3 participants