-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Add Global Search to Mobile #7477
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7477 +/- ##
==========================================
- Coverage 55.38% 55.09% -0.29%
==========================================
Files 671 671
Lines 27013 27013
Branches 2633 2633
==========================================
- Hits 14961 14884 -77
- Misses 11328 11405 +77
Partials 724 724
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@rukmini-bose we might need to rebase this. we can sync some time this week and get it fixed |
42d4b47
to
5a1008a
Compare
ffab21b
to
7ffd4e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran locally and LGTM. I want us to set the focus to the input when the user expands the search input by tapping on the magnify glass (so they don't have to tap twice), but will follow that up with a new issue.
…rgin on results so there is room for close button, fix various landscape mode issues
…ike a popup and more full screen
b8e5c4b
to
9511b8c
Compare
.circleci/config.yml
Outdated
@@ -260,8 +285,11 @@ workflows: | |||
- e2e-test: | |||
name: e2e-stable | |||
suite: stable | |||
- e2e-mobile | |||
- mem-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is broken
@@ -27,6 +27,11 @@ | |||
aria-label="Search Results Dropdown" | |||
class="c-gsearch__dropdown" | |||
> | |||
<button | |||
aria-label="Close" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was this button for?
Closes #7349 #6530
Describe your changes:
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist