Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plot] Fix plot swatch behavior when vertical space is small #7493

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

rukmini-bose
Copy link
Contributor

@rukmini-bose rukmini-bose commented Feb 9, 2024

Closes #7490

Describe your changes:

  • Add overflow: hidden to swatch container such that when the plot is vertically compressed, the container does not scroll, but rather hides overflow swatches.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.17%. Comparing base (ceeb761) to head (a3a81ba).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7493      +/-   ##
==========================================
+ Coverage   56.15%   56.17%   +0.01%     
==========================================
  Files         672      672              
  Lines       27112    27112              
  Branches     2635     2635              
==========================================
+ Hits        15226    15230       +4     
+ Misses      11561    11557       -4     
  Partials      325      325              
Flag Coverage Δ
e2e-full 23.60% <ø> (ø)
e2e-stable 59.96% <ø> (+0.02%) ⬆️
unit 49.09% <ø> (-0.03%) ⬇️

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceeb761...a3a81ba. Read the comment docs.

Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

image

@akhenry akhenry enabled auto-merge (squash) February 26, 2024 21:44
@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Feb 27, 2024
@unlikelyzero unlikelyzero added the needs:test instructions Missing testing notes label Mar 3, 2024
@unlikelyzero unlikelyzero self-requested a review March 3, 2024 16:18
@akhenry akhenry requested review from akhenry and removed request for unlikelyzero March 11, 2024 21:29
@rukmini-bose
Copy link
Contributor Author

Testing Instructions:

  1. Make an Overlay Plot with maybe 4+ items in at least one of the Y-Axis.
  2. Drag that into a Display Layout.
  3. Make the Overlay Plot vertically very small, then expand the legend.
  4. Verify that the overflow swatches are being hidden under the legend, such that the legend is visible.

@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 14, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 14, 2024
@akhenry akhenry merged commit 5fc5c13 into master Mar 14, 2024
37 of 45 checks passed
@akhenry akhenry deleted the fix-plot-vertical-space branch March 14, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlay Plot swatches do not handle compressed vertical space well
4 participants