Bypass cache/dirty when canceling transaction #7503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
scottbell
commented
Feb 15, 2024
| @@ -32,7 +32,7 @@ | |||
| class="c-swatch" | |||
| :style="{ background: options.value }" | |||
| role="img" | |||
| :aria-label="None" | |||
| aria-label="None" | |||
There was a problem hiding this comment.
Driveby as it was throwing a warning every time the toolbar was brought up.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7503 +/- ##
=======================================
Coverage 55.39% 55.39%
=======================================
Files 671 671
Lines 27010 27010
Branches 2631 2631
=======================================
Hits 14961 14961
- Misses 11326 11328 +2
+ Partials 723 721 -2
*This pull request uses carry forward flags. Click here to find out more.
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
unlikelyzero
approved these changes
Feb 15, 2024
ozyx
approved these changes
Feb 15, 2024
| @@ -35,7 +35,7 @@ const defaultFrameBorderColor = '#e6b8af'; //default border color | |||
| const defaultBorderTargetColor = '#acacac'; | |||
| const defaultTextColor = '#acacac'; // default text color | |||
| const inheritedColor = '#acacac'; // inherited from the body style | |||
| const pukeGreen = '#6aa84f'; //Ugliest green known to man | |||
| const pukeGreen = '#6aa84f'; //Ugliest green known to man 🤮 | |||
| @@ -411,4 +411,39 @@ test.describe('Flexible Layout styling', () => { | |||
| page.getByLabel('StackedPlot1 Frame').getByLabel('Stacked Plot Style Target') | |||
| ); | |||
| }); | |||
|
|
|||
| test('Styling, and then canceling reverts to previous style', async ({ page }) => { | |||
| @@ -75,10 +75,10 @@ export default class Transaction { | |||
|
|
|||
| _clear() { | |||
| const promiseArray = []; | |||
| const refresh = this.objectAPI.refresh.bind(this.objectAPI); | |||
| const action = (obj) => this.objectAPI.refresh(obj, true); | |||
There was a problem hiding this comment.
we love our arrow functions don't we folks? nice change
| * @returns {Promise} the provided object, updated to reflect the latest persisted state of the object. | ||
| */ | ||
| async refresh(domainObject) { | ||
| const refreshedObject = await this.get(domainObject.identifier); | ||
| async refresh(domainObject, forceRemote = false) { |
There was a problem hiding this comment.
nice! the forceRemote option on get() came in handy @jvigliotta
ozyx
deleted the
7233-transactions-general-issue-with-transactions-in-openmct
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7233
Describe your changes:
When canceling a transaction, we call
refreshon the object, this in turn callsget, which by default can use a cached/dirty version of the object. This isn't very helpful as the cached object is the dirty object we're trying revert! To fix this, we instead useforceRemoteon thegetto get the untouched version of the object.All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist