Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Metadata Time System Error for Missing Objects #7565

Merged
merged 19 commits into from
Mar 14, 2024
Merged

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented Mar 7, 2024

Closes #7476

Describe your changes:

Modified Stacked Plots to not show Missing Objects. Added a check in Telemetry Collections for missing objects before displaying telemetry metadata time system error.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@jvigliotta jvigliotta added this to the Target:4.0.0 milestone Mar 7, 2024
@jvigliotta jvigliotta requested a review from ozyx March 7, 2024 22:57
@jvigliotta jvigliotta changed the title Mct7476 Prevent Metadata Time System Error for Missing Objects Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 56.17%. Comparing base (faed27c) to head (a18cf8d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7565      +/-   ##
==========================================
+ Coverage   56.15%   56.17%   +0.01%     
==========================================
  Files         672      672              
  Lines       27104    27112       +8     
  Branches     2630     2635       +5     
==========================================
+ Hits        15220    15229       +9     
+ Misses      11561    11558       -3     
- Partials      323      325       +2     
Flag Coverage Δ
e2e-full 23.60% <16.66%> (-0.01%) ⬇️
e2e-stable 59.92% <33.33%> (-0.04%) ⬇️
unit 49.14% <56.00%> (+0.01%) ⬆️
Files Coverage Δ
src/api/objects/ObjectAPI.js 90.86% <100.00%> (ø)
src/api/telemetry/TelemetryCollection.js 86.43% <100.00%> (+0.06%) ⬆️
src/plugins/plot/configuration/SeriesCollection.js 90.78% <50.00%> (-1.11%) ⬇️
src/ui/components/ObjectFrame.vue 4.16% <0.00%> (+0.08%) ⬆️
src/plugins/plot/stackedPlot/StackedPlotItem.vue 27.53% <0.00%> (ø)
src/plugins/plot/stackedPlot/StackedPlot.vue 61.90% <0.00%> (-1.83%) ⬇️
src/ui/layout/BrowseBar.vue 45.45% <69.23%> (-1.43%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faed27c...a18cf8d. Read the comment docs.

Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for now will elaborate later but I have a good reason I swear

src/api/telemetry/TelemetryCollection.js Show resolved Hide resolved
src/plugins/plot/configuration/SeriesCollection.js Outdated Show resolved Hide resolved
src/plugins/plot/stackedPlot/StackedPlot.vue Outdated Show resolved Hide resolved
src/plugins/plot/stackedPlot/StackedPlotItem.vue Outdated Show resolved Hide resolved
@jvigliotta jvigliotta requested a review from ozyx March 8, 2024 19:39
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 13, 2024
@ozyx ozyx enabled auto-merge (squash) March 13, 2024 04:55
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 13, 2024
@ozyx ozyx disabled auto-merge March 13, 2024 05:38
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 13, 2024
@ozyx ozyx removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 13, 2024
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 13, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 13, 2024
@akhenry akhenry merged commit 10eb749 into master Mar 14, 2024
21 checks passed
@akhenry akhenry deleted the mct7476 branch March 14, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Erroneous "Telemetry metadata does not match the active time system" notifications
4 participants