Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow inspector pane content to scroll vertically #7567

Merged
merged 15 commits into from
Mar 13, 2024
Merged

allow inspector pane content to scroll vertically #7567

merged 15 commits into from
Mar 13, 2024

Conversation

davetsay
Copy link
Contributor

@davetsay davetsay commented Mar 8, 2024

Closes #7566

Describe your changes:

Introduced in #7037

  • Kept horizontal overflow-x: hidden to prevent horizontal pane leaking
  • Added vertical overflow-y: auto to allow vertical scrolling

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@davetsay davetsay added this to the Target:4.0.0 milestone Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.02%. Comparing base (6486263) to head (22b4d66).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7567      +/-   ##
==========================================
- Coverage   59.75%   56.02%   -3.74%     
==========================================
  Files         430      672     +242     
  Lines       13454    27108   +13654     
  Branches        0     2629    +2629     
==========================================
+ Hits         8040    15188    +7148     
- Misses       5414    11598    +6184     
- Partials        0      322     +322     
Flag Coverage Δ
e2e-full 23.60% <ø> (ø)
e2e-stable 59.70% <ø> (+0.03%) ⬆️
unit 49.08% <ø> (?)
Files Coverage Δ
.../inspectorViews/properties/PropertiesComponent.vue 86.30% <ø> (ø)

... and 376 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6486263...22b4d66. Read the comment docs.

@davetsay
Copy link
Contributor Author

davetsay commented Mar 8, 2024

Do it @unlikelyzero . Block it for visual tests.

@ozyx ozyx added the type:bug label Mar 8, 2024
davetsay and others added 7 commits March 8, 2024 15:51
- Fixed scrolling to only apply to the area below the Inspector tabs.
- Removed unneeded padding in pane.scss.
- Alignment fixes to related scroll elements in tree.
Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed up changes that altered this solution: we don't want the whole Inspector area to scroll, just the area beneath the tabs. With that, LGTM.

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 12, 2024
@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Mar 12, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 12, 2024
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 12, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 12, 2024
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 13, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 13, 2024
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 13, 2024
@ozyx ozyx enabled auto-merge (squash) March 13, 2024 18:59
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 13, 2024
@ozyx ozyx merged commit 18e976a into master Mar 13, 2024
36 checks passed
@ozyx ozyx deleted the mct7566 branch March 13, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CSS] Inspector can no longer be scrolled vertically if contents overflow
3 participants