-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow inspector pane content to scroll vertically #7567
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7567 +/- ##
==========================================
- Coverage 59.75% 56.02% -3.74%
==========================================
Files 430 672 +242
Lines 13454 27108 +13654
Branches 0 2629 +2629
==========================================
+ Hits 8040 15188 +7148
- Misses 5414 11598 +6184
- Partials 0 322 +322
... and 376 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Do it @unlikelyzero . Block it for visual tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed up changes that altered this solution: we don't want the whole Inspector area to scroll, just the area beneath the tabs. With that, LGTM.
Closes #7566
Describe your changes:
Introduced in #7037
overflow-x: hidden
to prevent horizontal pane leakingoverflow-y: auto
to allow vertical scrollingAll Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist