Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC Popup] Fix Calendar so it is not cutoff #7596

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Conversation

rukmini-bose
Copy link
Contributor

@rukmini-bose rukmini-bose commented Mar 15, 2024

Closes #7594

Describe your changes:

  • Add and change CSS classes such that calendar popups do not open up in a way that get cut off.
  • Add code to ITC such that calendar popup opens up from the bottom, rather than the top

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.15%. Comparing base (f189a4d) to head (49bfe22).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7596      +/-   ##
==========================================
- Coverage   56.15%   56.15%   -0.01%     
==========================================
  Files         672      672              
  Lines       27111    27111              
  Branches     2635     2635              
==========================================
- Hits        15225    15223       -2     
- Misses      11560    11562       +2     
  Partials      326      326              
Flag Coverage Δ
e2e-full 23.60% <ø> (ø)
e2e-stable 59.86% <ø> (-0.09%) ⬇️
unit 49.11% <ø> (+<0.01%) ⬆️
Files Coverage Δ
src/plugins/timeConductor/DatePicker.vue 55.76% <ø> (ø)
src/plugins/timeConductor/TimePopupFixed.vue 32.91% <ø> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f189a4d...49bfe22. Read the comment docs.

Copy link
Collaborator

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment update and this is good to go!

@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Mar 15, 2024
@unlikelyzero unlikelyzero added type:bug pr:e2e:couchdb npm run test:e2e:couchdb labels Mar 15, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 15, 2024
@unlikelyzero unlikelyzero enabled auto-merge (squash) March 16, 2024 21:52
@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 18, 2024
@unlikelyzero unlikelyzero enabled auto-merge (squash) March 18, 2024 23:23
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 18, 2024
@unlikelyzero unlikelyzero merged commit b7b9ccb into master Mar 18, 2024
19 of 21 checks passed
@unlikelyzero unlikelyzero deleted the fix-tc-popup branch March 18, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants