Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize plans properly #7597

Merged

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Mar 15, 2024

Closes #7587

Describe your changes:

Ensure element isn't null for the resize observer, and that we're deeply watching the size.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@scottbell scottbell linked an issue Mar 15, 2024 that may be closed by this pull request
7 tasks
@scottbell scottbell added this to the Target:4.0.0 milestone Mar 15, 2024
@scottbell scottbell changed the title Ensure we resize plans properly Resize plans properly Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 56.17%. Comparing base (4027eae) to head (e4250d3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7597      +/-   ##
==========================================
- Coverage   56.46%   56.17%   -0.30%     
==========================================
  Files         672      672              
  Lines       27112    27111       -1     
  Branches     2635     2635              
==========================================
- Hits        15310    15229      -81     
- Misses      11477    11557      +80     
  Partials      325      325              
Flag Coverage Δ
e2e-full 23.60% <ø> (-18.12%) ⬇️
e2e-stable 59.93% <ø> (-0.01%) ⬇️
unit 49.13% <66.66%> (+<0.01%) ⬆️
Files Coverage Δ
src/ui/components/TimeSystemAxis.vue 64.06% <66.66%> (-0.56%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4027eae...e4250d3. Read the comment docs.

Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with 1 nitpick that you could take or leave

src/ui/components/TimeSystemAxis.vue Outdated Show resolved Hide resolved
@ozyx
Copy link
Member

ozyx commented Mar 15, 2024

I wonder if we can have a visual test that resizes a plan? that might catch a regression like this.

@scottbell scottbell marked this pull request as ready for review March 18, 2024 10:12
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 18, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 18, 2024
@ozyx ozyx merged commit f189a4d into master Mar 18, 2024
21 checks passed
@ozyx ozyx deleted the 7587-resizing-the-window-causes-plan-activities-to-stay-fixed branch March 18, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizing the window causes Plan activities to stay fixed
2 participants