Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry Table] Telemetry mode bug fixes #7601

Merged
merged 21 commits into from
Mar 19, 2024
Merged

Conversation

jvigliotta
Copy link
Contributor

Closes #7268

Describe your changes:

Specifically addresses these issues: #7268 (comment)

  • will set any existing tables to the defaults for TelemetryMode (default mode is limited)
  • fixes error on save
  • fixes telemetry mode and persist mode changes not working when changed at the same time

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@jvigliotta jvigliotta added this to the Target:4.0.0 milestone Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 56.15%. Comparing base (a01f210) to head (db41a99).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7601      +/-   ##
==========================================
- Coverage   56.63%   56.15%   -0.48%     
==========================================
  Files         672      672              
  Lines       27111    27116       +5     
  Branches     2635     2635              
==========================================
- Hits        15354    15228     -126     
- Misses      11432    11561     +129     
- Partials      325      327       +2     
Flag Coverage Δ
e2e-full 23.59% <25.00%> (-24.11%) ⬇️
e2e-stable 59.92% <87.50%> (-0.03%) ⬇️
unit 49.12% <66.66%> (-0.02%) ⬇️
Files Coverage Δ
src/plugins/telemetryTable/TelemetryTable.js 79.80% <100.00%> (-0.99%) ⬇️
...gins/telemetryTable/TelemetryTableConfiguration.js 63.63% <100.00%> (+0.47%) ⬆️
src/plugins/telemetryTable/TelemetryTableType.js 100.00% <100.00%> (ø)
src/plugins/telemetryTable/TelemetryTableView.js 89.47% <ø> (ø)
src/plugins/telemetryTable/plugin.js 100.00% <100.00%> (ø)
...s/telemetryTable/TableConfigurationViewProvider.js 62.50% <0.00%> (ø)
...ugins/telemetryTable/components/TableComponent.vue 41.44% <42.85%> (-0.41%) ⬇️

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a01f210...db41a99. Read the comment docs.

@jvigliotta jvigliotta added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 15, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 15, 2024
Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flawless

@jvigliotta jvigliotta added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 15, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 15, 2024
@jvigliotta jvigliotta added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 19, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 19, 2024
@jvigliotta jvigliotta enabled auto-merge (squash) March 19, 2024 02:33
@jvigliotta jvigliotta merged commit fb396ac into master Mar 19, 2024
21 checks passed
@jvigliotta jvigliotta deleted the tt-bug-investigation branch March 19, 2024 02:34
@unlikelyzero unlikelyzero added the notable_change A change which should be noted in the changelog label Apr 2, 2024
@ozyx ozyx removed the notable_change A change which should be noted in the changelog label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve telemetry table performance
4 participants