Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Parallelize visual test runs #7618

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Conversation

unlikelyzero
Copy link
Collaborator

Closes #7615

Describe your changes:

Originally, the intent of this ticket was to make sure we only had one worker per shard. Upon investigation, I discovered that we were already setting workers to 1.
This ticket improves runtime by running the tests in parallel

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Mar 19, 2024
@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Mar 19, 2024
@@ -220,15 +220,20 @@ jobs:
equal: [42, 42] # Always run codecov reports regardless of test failure https://discuss.circleci.com/t/make-custom-command-run-always-with-when-always/38957/2
steps:
- generate_and_store_version_and_filesystem_artifacts
visual-a11y-tests:
visual-a11y:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

driveby to change the name

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.17%. Comparing base (b2b0837) to head (e492a98).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7618      +/-   ##
==========================================
- Coverage   56.58%   56.17%   -0.42%     
==========================================
  Files         672      672              
  Lines       27128    27128              
  Branches     2635     2635              
==========================================
- Hits        15351    15239     -112     
- Misses      11450    11562     +112     
  Partials      327      327              
Flag Coverage Δ
e2e-full 23.57% <ø> (-24.13%) ⬇️
e2e-stable 59.93% <ø> (+0.02%) ⬆️
unit 49.11% <ø> (+<0.01%) ⬆️

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b0837...e492a98. Read the comment docs.

Copy link
Contributor

@scottbell scottbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unlikelyzero unlikelyzero enabled auto-merge (squash) March 19, 2024 20:10
@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 19, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 19, 2024
@unlikelyzero unlikelyzero merged commit 42085a4 into master Mar 20, 2024
19 checks passed
@unlikelyzero unlikelyzero deleted the parallelize-visual-tests branch March 20, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Split up visual tests to be single shards
2 participants