-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Parallelize visual test runs #7618
Conversation
@@ -220,15 +220,20 @@ jobs: | |||
equal: [42, 42] # Always run codecov reports regardless of test failure https://discuss.circleci.com/t/make-custom-command-run-always-with-when-always/38957/2 | |||
steps: | |||
- generate_and_store_version_and_filesystem_artifacts | |||
visual-a11y-tests: | |||
visual-a11y: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
driveby to change the name
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7618 +/- ##
==========================================
- Coverage 56.58% 56.17% -0.42%
==========================================
Files 672 672
Lines 27128 27128
Branches 2635 2635
==========================================
- Hits 15351 15239 -112
- Misses 11450 11562 +112
Partials 327 327
see 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #7615
Describe your changes:
Originally, the intent of this ticket was to make sure we only had one worker per shard. Upon investigation, I discovered that we were already setting workers to 1.
This ticket improves runtime by running the tests in parallel
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist