-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry Tables] Don't mutate configuration if object is not able to be persisted #7626
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7626 +/- ##
==========================================
- Coverage 56.58% 56.16% -0.43%
==========================================
Files 672 672
Lines 27128 27131 +3
Branches 2635 2635
==========================================
- Hits 15351 15238 -113
- Misses 11450 11566 +116
Partials 327 327
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change.
I think this is worthy of an e2e test, but the change looks good.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7626 +/- ##
==========================================
- Coverage 56.64% 56.32% -0.32%
==========================================
Files 672 672
Lines 27122 27125 +3
Branches 2632 2632
==========================================
- Hits 15362 15277 -85
- Misses 11432 11520 +88
Partials 328 328
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Test on openmct-yamcs side |
Closes #7625
VIPEROMCT-428
Describe your changes:
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist