Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry Tables] Don't mutate configuration if object is not able to be persisted #7626

Merged
merged 10 commits into from
Apr 4, 2024

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented Mar 20, 2024

Closes #7625
VIPEROMCT-428

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.16%. Comparing base (b2b0837) to head (f72ddf7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7626      +/-   ##
==========================================
- Coverage   56.58%   56.16%   -0.43%     
==========================================
  Files         672      672              
  Lines       27128    27131       +3     
  Branches     2635     2635              
==========================================
- Hits        15351    15238     -113     
- Misses      11450    11566     +116     
  Partials      327      327              
Flag Coverage Δ
e2e-full 23.57% <0.00%> (-24.14%) ⬇️
e2e-stable 59.93% <50.00%> (+0.03%) ⬆️
unit 49.11% <75.00%> (+<0.01%) ⬆️
Files Coverage Δ
...gins/telemetryTable/TelemetryTableConfiguration.js 63.75% <75.00%> (+0.11%) ⬆️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b0837...f72ddf7. Read the comment docs.

Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change.
I think this is worthy of an e2e test, but the change looks good.

@ozyx ozyx modified the milestones: Target:4.0.0, Target:4.0.1 Apr 2, 2024
@akhenry akhenry enabled auto-merge (squash) April 3, 2024 00:42
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.32%. Comparing base (311ad0b) to head (6d53e85).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7626      +/-   ##
==========================================
- Coverage   56.64%   56.32%   -0.32%     
==========================================
  Files         672      672              
  Lines       27122    27125       +3     
  Branches     2632     2632              
==========================================
- Hits        15362    15277      -85     
- Misses      11432    11520      +88     
  Partials      328      328              
Flag Coverage Δ
e2e-full 23.63% <0.00%> (-18.41%) ⬇️
e2e-stable 60.35% <50.00%> (-0.06%) ⬇️
unit 49.08% <75.00%> (-0.05%) ⬇️
Files Coverage Δ
...gins/telemetryTable/TelemetryTableConfiguration.js 63.75% <75.00%> (+0.11%) ⬆️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 311ad0b...6d53e85. Read the comment docs.

@ozyx
Copy link
Contributor

ozyx commented Apr 4, 2024

Test on openmct-yamcs side

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Apr 4, 2024
@ozyx ozyx enabled auto-merge (squash) April 4, 2024 00:35
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Apr 4, 2024
@ozyx ozyx merged commit de3dad0 into master Apr 4, 2024
22 checks passed
@ozyx ozyx deleted the static-table-performance branch April 4, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Telemetry Tables] Telemetry mode changes break on objects that are unable to be persisted
6 participants