Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🤖 beep boop beep, you forgot an await 🤖 #7630

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented Mar 20, 2024

Closes #7631

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx added the type:bug label Mar 20, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Mar 20, 2024
@ozyx ozyx requested a review from akhenry March 20, 2024 19:09
@unlikelyzero unlikelyzero self-requested a review March 20, 2024 19:17
@shefalijoshi shefalijoshi requested review from shefalijoshi and removed request for akhenry March 20, 2024 19:40
Copy link
Contributor

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Author checklist needs to be checked off and original issue needs repro steps.
The rest looks good. Smoke tested on viper-openmct locally.

@akhenry akhenry enabled auto-merge (squash) March 20, 2024 20:05
@ozyx ozyx disabled auto-merge March 20, 2024 20:09
@ozyx
Copy link
Member Author

ozyx commented Mar 20, 2024

@scottbell to add a test momentarily

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 20, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 20, 2024
@scottbell scottbell enabled auto-merge (squash) March 20, 2024 20:20
@scottbell scottbell merged commit f504ee2 into master Mar 20, 2024
25 checks passed
@scottbell scottbell deleted the robot-done-fixed-it branch March 20, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting ConditionSet historical telemetry fails
4 participants