Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gha): run prcop workflow on milestone #7647

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented Mar 27, 2024

Closes #7648

Describe your changes:

Turns out there's a milestoned and demilestoned event on pull_requests that we can use to re-trigger the milestone check.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx requested a review from unlikelyzero March 27, 2024 03:32
@ozyx ozyx added this to the Target:4.0.1 milestone Mar 27, 2024
@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Mar 27, 2024
@ozyx ozyx marked this pull request as ready for review March 27, 2024 03:35
@ozyx ozyx changed the title chore: run prcop workflow on milestone chore(gha): run prcop workflow on milestone Mar 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.30%. Comparing base (5b4ee19) to head (99b5b77).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7647   +/-   ##
=======================================
  Coverage   56.30%   56.30%           
=======================================
  Files         672      672           
  Lines       27120    27120           
  Branches     2632     2632           
=======================================
  Hits        15270    15270           
  Misses      11522    11522           
  Partials      328      328           
Flag Coverage Δ
e2e-full 23.64% <ø> (ø)
e2e-stable 60.36% <ø> (ø)
unit 49.09% <ø> (ø)

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b4ee19...99b5b77. Read the comment docs.

@unlikelyzero unlikelyzero merged commit 46823ec into master Mar 27, 2024
23 of 30 checks passed
@unlikelyzero unlikelyzero deleted the fix-milestone-check branch March 27, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot PRs are blocked on milestone check
3 participants