Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Handle the case where the pasted data is not an image" #7668

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Revert "Handle the case where the pasted data is not an image" #7668

merged 1 commit into from
Apr 4, 2024

Conversation

akhenry
Copy link
Contributor

@akhenry akhenry commented Apr 4, 2024

Reverts #7628

The modified code makes the situation worse, pasting is completely broken.

@akhenry akhenry requested a review from ozyx April 4, 2024 21:56
@akhenry akhenry marked this pull request as ready for review April 4, 2024 21:56
@ozyx ozyx added this to the Target:4.0.1 milestone Apr 4, 2024
@ozyx ozyx added the type:bug label Apr 4, 2024
ozyx
ozyx approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akhenry akhenry merged commit b18aa48 into master Apr 4, 2024
17 of 26 checks passed
@akhenry akhenry deleted the revert-7628-fix-notebook-paste-text-or-image branch April 4, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozyx ozyx ozyx approved these changes

Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@akhenry @ozyx @unlikelyzero