Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(webpack): destruct version from pkgJson #7713

Merged
merged 1 commit into from
May 7, 2024

Conversation

evenstensberg
Copy link
Contributor

@evenstensberg evenstensberg commented May 6, 2024

Describe your changes:

Syntax sugar

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx added this to the Target:4.0.0 milestone May 6, 2024
@ozyx ozyx added source:community Community contribution or request type:maintenance tests, chores, or project maintenance labels May 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.39%. Comparing base (b3d3465) to head (622d715).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7713      +/-   ##
==========================================
- Coverage   56.81%   56.39%   -0.42%     
==========================================
  Files         673      673              
  Lines       27185    27185              
  Branches     2635     2635              
==========================================
- Hits        15445    15331     -114     
- Misses      11412    11524     +112     
- Partials      328      330       +2     
Flag Coverage Δ
e2e-full 23.55% <ø> (-18.24%) ⬇️
e2e-stable 59.98% <ø> (ø)
unit 49.20% <ø> (-0.17%) ⬇️

see 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d3465...622d715. Read the comment docs.

Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ozyx ozyx merged commit 17bc6cb into nasa:master May 7, 2024
42 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source:community Community contribution or request type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants