Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#7806): chore: re-enable perf/mem tests on PR + fix broken locator in imagery perf test #7812

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Aug 13, 2024

cherry-picks #7806 (Issues #7807 #7808) into release/4.0.0

… perf test (#7806)

* test: fix broken locator in imagery perf test

* Prevent this from happening

* make rule explicit

* test: maintain `locator()` pattern for contract tests

* test(couchdb): try some new techniques to stabilize the test

* Revert "test(couchdb): try some new techniques to stabilize the test"

This reverts commit 9aa1ea9.

* chore: revert to `networkidle` and disable eslint rule

* test: add `@network` annotation for tests with real network requests

---------

Co-authored-by: Hill, John (ARC-TI)[KBR Wyle Services, LLC] <[email protected]>
@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Aug 13, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Aug 13, 2024
@ozyx ozyx requested a review from unlikelyzero August 13, 2024 22:03
@ozyx ozyx changed the base branch from master to release/4.0.0 August 13, 2024 22:03
@ozyx ozyx requested a review from akhenry August 13, 2024 22:06
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 13, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 13, 2024
@ozyx ozyx changed the title cherry-pick(#7806): chore: re-enable perf/mem tests on PR + fix broken locator in imagery perf test (#7806) cherry-pick(#7806): chore: re-enable perf/mem tests on PR + fix broken locator in imagery perf test Aug 13, 2024
@ozyx ozyx enabled auto-merge (squash) August 13, 2024 22:16
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.74%. Comparing base (0413e77) to head (6e809cc).

Additional details and impacted files
@@                Coverage Diff                @@
##           release/4.0.0    #7812      +/-   ##
=================================================
- Coverage          57.32%   56.74%   -0.58%     
=================================================
  Files                674      674              
  Lines              27283    27283              
  Branches            2669     2669              
=================================================
- Hits               15639    15481     -158     
- Misses             11305    11463     +158     
  Partials             339      339              
Flag Coverage Δ
e2e-ci 60.06% <ø> (-0.99%) ⬇️
e2e-full 23.52% <ø> (-24.44%) ⬇️
unit 49.40% <ø> (-0.02%) ⬇️

see 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0413e77...6e809cc. Read the comment docs.

@ozyx ozyx merged commit d786452 into release/4.0.0 Aug 13, 2024
39 of 46 checks passed
@ozyx ozyx deleted the cherry-pick-mct7806 branch August 13, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants