Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaner create-map versioning + EE credential bug #111

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Cleaner create-map versioning + EE credential bug #111

merged 2 commits into from
Oct 6, 2022

Conversation

ivanzvonkov
Copy link
Contributor

@ivanzvonkov ivanzvonkov commented Oct 3, 2022 •
edited
Loading

This PR:

  • Adds a cleaner version update if the map has already been made
  • Adds the ability to pass credentials to EarthEngineExporter to fix ee authentication issue
  • Sets the Gcloud project environment variable in the create-map notebook

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@ivanzvonkov ivanzvonkov changed the title Cleaner create-map versioning Cleaner create-map versioning + EE credential bug Oct 5, 2022
@adebowaledaniel
Copy link

LGTM!

@ivanzvonkov ivanzvonkov merged commit 9ff4bf9 into main Oct 6, 2022
@ivanzvonkov ivanzvonkov deleted the create-map-update branch October 6, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adebowaledaniel adebowaledaniel adebowaledaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanzvonkov @adebowaledaniel