Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cropharvest.bands.BANDS_MAX to normalize data in train.py #28

Merged
merged 5 commits into from
Jul 7, 2022

Conversation

gabrieltseng
Copy link
Contributor

Addresses #14

@ivanzvonkov
Copy link
Contributor

@gabrieltseng CI fix now in main

@gabrieltseng
Copy link
Contributor Author

gabrieltseng commented Jun 16, 2022

Confirmed it works: https://gist.github.com/gabrieltseng/b1decd18812012c32a4d22064ad602bb

@ivanzvonkov , the next steps would be updating cropharvest on PyPi so that we can update the dependencies here; let me know if this works for you.

@ivanzvonkov
Copy link
Contributor

Yes: nasaharvest/cropharvest#92

@ivanzvonkov
Copy link
Contributor

Cropharvest is updated: https://pypi.org/project/cropharvest/

@gabrieltseng
Copy link
Contributor Author

https://gist.github.com/gabrieltseng/1bc41e2ac366f7ccdbaad84c43c23e2a

Updated and tested again

Copy link
Contributor

@ivanzvonkov ivanzvonkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants