Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update 1142 format input number #1167

Closed
wants to merge 2 commits into from
Closed

update 1142 format input number #1167

wants to merge 2 commits into from

Conversation

DinhThaiVV
Copy link
Contributor

Issue: #1142

Screenshot 2024-10-14 100852

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 14, 2024

Quality Gate Passed Quality Gate passed for 'backoffice'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@DinhThaiVV DinhThaiVV linked an issue Oct 14, 2024 that may be closed by this pull request
format number in input field #1142
Closed
khanhtrand
khanhtrand reviewed Oct 14, 2024
View reviewed changes
backoffice/common/items/Input.tsx
@@ -60,6 +62,110 @@ export const Input = <T extends FieldValues>({
</div>
);

export const FormatNumberInput = <T extends FieldValues>({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use react-number-format library instead of handling manually
https://s-yadav.github.io/react-number-format/docs/props

@DinhThaiVV DinhThaiVV closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanhtrand khanhtrand khanhtrand left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

format number in input field
2 participants
@DinhThaiVV @khanhtrand