Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1183 Feat: Modal for selecting the display-type of Product Option and configuring the Storefront view to integrate with the display-type #1263

Merged
merged 9 commits into from
Nov 14, 2024

Conversation

khanhduzz
Copy link
Contributor

@khanhduzz khanhduzz commented Nov 6, 2024

Model for customize Product Option in Backoffice and improve Storefront UI

The origin issue: #1183 [Storefront][Product] - Show Product Color Options as colored label instead text name label

Overview:

  • Add a model in Backoffice when create/update product -> user is able to change the display type of option: color/text; when select display with color, they are also able to pick a specific color.
  • The Generate Combine button will now generate combinations of multiple different option values together, rather than just a single one.
  • Configured display Product Combination in Storefront, show color/text based on the selected display type.

Backoffice:

  • Create product:

image

  • Update product:

Screenshot 2024-11-12 094226

  • Selected Display Type and value:
Screenshot 1 Screenshot 2
Select display type Select display value

Storefront page:

Screenshot 2024-11-05 165658

Screenshot 2024-11-05 165706

@khanhduzz khanhduzz changed the title feat: Add selector for product option value display Feat: Add a modal for selecting the display type of product option values and configuring the storefront view to integrate with the selected display type Nov 6, 2024
@khanhduzz khanhduzz changed the title Feat: Add a modal for selecting the display type of product option values and configuring the storefront view to integrate with the selected display type Feat: Modal for selecting the display type of product option and configuring the storefront view to integrate with the display type Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Product Coverage Report

Overall Project 78.16% -0.04%
Files changed 95.45% 🍏

File Coverage
ProductOptionValueGetVm.java 100% 🍏
ProductPostVm.java 100% 🍏
ProductPutVm.java 100% 🍏
ProductOptionValueDisplay.java 100% 🍏
ProductVariationPutVm.java 100% 🍏
ProductVariationPostVm.java 100% 🍏
ProductService.java 77.99% -0.1% 🍏

@khanhduzz khanhduzz changed the title Feat: Modal for selecting the display type of product option and configuring the storefront view to integrate with the display type #1183 Feat: Modal for selecting the display type of product option and configuring the storefront view to integrate with the display type Nov 6, 2024
@khanhduzz khanhduzz changed the title #1183 Feat: Modal for selecting the display type of product option and configuring the storefront view to integrate with the display type #1183 Feat: Modal for selecting the display-type of Product Option and configuring the Storefront view to integrate with the display-type Nov 6, 2024
@khanhduzz khanhduzz marked this pull request as ready for review November 6, 2024 06:46
@mochacr0
Copy link
Contributor

mochacr0 commented Nov 8, 2024

@khanhduzz The product option chips look great. However, the delete button is currently integrated within the chip value, which means clicking anywhere on the chip will remove it. Could we add a separate remove button outside the chip value? This change would help prevent accidental deletions by making the delete action more distinct.

Current:
Screenshot 2024-11-08 113217

Propose:
Screenshot 2024-11-08 113343

@khanhduzz
Copy link
Contributor Author

Hi @mochacr0, your suggestion to enhance the badges is great, but for now, let's focus solely on functionality. Our website is currently facing issues with product creation and updates. We can create a new ticket to address and improve badge upgrades later.
Thanks for your all comments, I will check it out and refactor code for more readable and consistent.

Copy link

sonarcloud bot commented Nov 12, 2024

Copy link

sonarcloud bot commented Nov 12, 2024

Copy link

sonarcloud bot commented Nov 12, 2024

@khanhduzz khanhduzz merged commit 978b380 into main Nov 14, 2024
12 checks passed
@khanhduzz khanhduzz deleted the #1183-product-option branch November 14, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Storefront][Product] - Show Product Color Options as colored label instead text name label
3 participants