Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1180 & #1237 create payment and order in paypal #1264

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

#1180 & #1237 create payment and order in paypal #1264

wants to merge 2 commits into from

Conversation

nashtech-tuannguyenhuu1
Copy link
Contributor

#1180 & #1237 create payment and order in paypal

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

Payment Paypal Coverage Report

Overall Project 80.24% 🍏
Files changed 100% 🍏

File Coverage
PaypalCreatePaymentRequest.java 100% 🍏
PaypalService.java 100% 🍏

@nashtech-tuannguyenhuu1 nashtech-tuannguyenhuu1 force-pushed the #1237-step2-order-refactor-create-order-paypal branch from 0abc373 to 5ff62c9 Compare November 6, 2024 10:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

Order Coverage Report

Overall Project 79.95% -1.68% ❌
Files changed 91.72% 🍏

File Coverage
AppKafkaListenerConfigurer.java 100% 🍏
CheckoutController.java 100% 🍏
PaymentUpdateConsumer.java 100% 🍏
CheckoutPaymentVm.java 100% 🍏
CheckoutPostVm.java 100% 🍏
CheckoutVm.java 100% 🍏
OrderAddressPostVm.java 100% 🍏
CheckoutMapper.java 100% 🍏
OrderStatusConsumer.java 97.38% -2.62% 🍏
CheckoutState.java 95.71% 🍏
CheckoutProgress.java 95.24% -4.76% 🍏
PaymentService.java 82.76% -17.24% 🍏
CheckoutService.java 81.25% 🍏
PaymentMethod.java 78.13% -21.88% 🍏
JsonUtils.java 56.31% -43.69% ❌
Constants.java 0% 🍏

@nashtech-tuannguyenhuu1 nashtech-tuannguyenhuu1 force-pushed the #1237-step2-order-refactor-create-order-paypal branch 2 times, most recently from cc45bb6 to 40f6a23 Compare November 7, 2024 03:38
@nashtech-tuannguyenhuu1 nashtech-tuannguyenhuu1 force-pushed the #1237-step2-order-refactor-create-order-paypal branch from 40f6a23 to a37f777 Compare November 7, 2024 04:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

Payment Coverage Report

Overall Project 68.62% -13.58% ❌
Files changed 66.06% 🍏

File Coverage
PaymentStatus.java 100% 🍏
CheckoutPaymentVm.java 100% 🍏
InitPaymentRequestVm.java 100% 🍏
PaymentCreateConsumer.java 99.44% -0.56% 🍏
PaymentService.java 94.42% -3% 🍏
OrderService.java 81.82% 🍏
JsonUtils.java 19.15% -80.85% ❌
PaypalHandler.java 11.63% -10.47% ❌
Constants.java 0% -50% ❌
PaymentController.java 0% -75.76% ❌
PaymentVm.java 0% ❌

@nashtech-tuannguyenhuu1 nashtech-tuannguyenhuu1 force-pushed the #1237-step2-order-refactor-create-order-paypal branch 3 times, most recently from cc8e102 to e5f2028 Compare November 11, 2024 14:57
@nashtech-tuannguyenhuu1 nashtech-tuannguyenhuu1 force-pushed the #1237-step2-order-refactor-create-order-paypal branch from e5f2028 to 12787e5 Compare November 11, 2024 15:02
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 11, 2024

Quality Gate Passed Quality Gate passed for 'payment-paypal'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 11, 2024

Quality Gate Passed Quality Gate passed for 'storefront'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 11, 2024

Quality Gate Passed Quality Gate passed for 'payment'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
66.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 11, 2024

Quality Gate Passed Quality Gate passed for 'order'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nashtech-tuannguyenhuu1 nashtech-tuannguyenhuu1 marked this pull request as draft November 12, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toannguyenk toannguyenk toannguyenk approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Yas's backlog
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nashtech-tuannguyenhuu1 @toannguyenk