Merge pull request #2222 from natalie-lang/regexp-escape

Fix Regexp.escape/quote not escaping dollar signs

spec/core/regexp/shared/new.rb

@@ -56,9 +56,7 @@ def obj.to_str() [] end
   end
 
   it "raises a RegexpError when passed an incorrect regexp" do
-      NATFIXME 'Update error message', exception: SpecFailedException, message: /but the message was/ do
-      -> { Regexp.send(@method, "^[$", 0) }.should raise_error(RegexpError, Regexp.new(Regexp.escape("premature end of char-class: /^[$/")))
-    end
+    -> { Regexp.send(@method, "^[$", 0) }.should raise_error(RegexpError, Regexp.new(Regexp.escape("premature end of char-class: /^[$/")))
   end
 
   it "does not set Regexp options if only given one argument" do

src/regexp_object.cpp

@@ -128,6 +128,7 @@ Value RegexpObject::quote(Env *env, Value string) {
         case '.':
         case '+':
         case '^':
+        case '$':
         case '[':
         case ']':
         case '(':

test/natalie/regexp_test.rb

@@ -96,6 +96,12 @@
     end
   end
 
+  describe '.escape and .quote' do
+    it 'escapes special characters' do
+      Regexp.escape('$').should == '\$'
+    end
+  end
+
   describe '#==' do
     it 'returns true if the regexp source is the same' do
       /foo/.should == /foo/