Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_gis_type remote file access #376

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

davemfish
Copy link
Contributor

Fixes #375

The cost of this change is a slightly less informative error message when a file does not exist. Instead of telling the user,
"{path} does not exist", we tell them "{path} could not be opened as a GDAL raster or vector".

That's somewhat unsatisfying, but as it is the much more commonly used get_raster_info and get_vector_info already give the "Could not open as a gdal.OF_RASTER" message when the file does not exist.

@davemfish davemfish requested a review from phargogh March 4, 2024 22:55
Copy link
Member

@phargogh phargogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great to me!

@phargogh phargogh merged commit 9adb14e into natcap:main Mar 4, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_gis_type should work on remote datasets
2 participants