-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to cython 3 #390
update to cython 3 #390
Conversation
@@ -8,8 +8,7 @@ jobs: | |||
fail-fast: false | |||
matrix: | |||
os: [windows-latest, macos-latest] | |||
python-version: [3.7, 3.8, 3.9, "3.10", "3.11", "3.12"] | |||
python-arch: [x64] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-arch
isn't needed here, and it caused an issue with the new ARM64 mac runners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bet this is a holdover from when we were still doing x86 builds. Makes sense to remove!
@@ -8,8 +8,7 @@ jobs: | |||
fail-fast: false | |||
matrix: | |||
os: [windows-latest, macos-latest] | |||
python-version: [3.7, 3.8, 3.9, "3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python 3.7 is end-of-life, we already removed it from the test workflow. And setup-python
couldn't find an ARM64 python 3.7 distribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, I just had one comment about dropping explicit support for python 3.7.
@@ -8,8 +8,7 @@ jobs: | |||
fail-fast: false | |||
matrix: | |||
os: [windows-latest, macos-latest] | |||
python-version: [3.7, 3.8, 3.9, "3.10", "3.11", "3.12"] | |||
python-arch: [x64] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bet this is a holdover from when we were still doing x86 builds. Makes sense to remove!
@@ -10,6 +10,7 @@ Unreleased Changes | |||
called with an invalid resampling algorithm. We now fall back to the | |||
underlying GDAL functions' error messages. | |||
https://github.com/natcap/pygeoprocessing/issues/387 | |||
* Updated to Cython 3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are removing testing/wheel-building support for python 3.7, should that also be noted here in HISTORY and also removed from the setup.py
trove classifiers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh you're right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me, thanks @emlys ! Just waiting for the tests to pass.
Update to Cython 3. Also fixes the github actions workflow for the new mac runners.