Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to make the Metaflow UI a mandatory component for a Metaflow deployment.
The problem I am having is with the UI
count
:terraform plan
fails with this error:The workaround suggested requires that we run the terraform apply in two stages. This is not desirable because:
Other things that I have tried:
null
, rather than an empty string, with the hope that terraform would check the type for the inputui_certificate_arn
variable. It did not.lifecycle
precondition that checks theui_certificate_arn
value, but these are not supported for modulesWe could also add a second variable,
create_ui
, which we instead use as the conditional to count, rather than the string value of the ARN. This would be similar to how the terraform-eks module handles conditional resource creation.The trade-off of this change is that we end up with a change in our terraform-aws fork that will almost certainly not be accepted into the upstream Outerbounds repo, which might make proposing changes later on harder.