-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: luarocks/rocks.nvim support #19
Conversation
Sorry for the delay on this, I've been swamped the last month. I'll take a closer look later today / over the next few days and get back to you |
Hey @NTBBloodbath, since you are part of neorocks, I'll let you handle this one :) Looks like you approved it. Feel free to merge whenever you feel it is ready |
Hey, sorry it took so long. It seems like I would need to add both my GitHub token for CI actions and my luarocks API key as well in the repository but as a contributor I don't seem to be able to. Not sure if you could create them in your GitHub account, otherwise feel free to slap me with an email and I'll reply back with the required keys to get this to work properly |
@NTBBloodbath so there is more work to do than just merge this? Like I wouldn't be able to merge it myself and everything just work? If I understand right, I would need to add an environment to this repository with your luarocks API key? Feel free to email me any information I need to set this up. Either my git email or the one on my website are fine |
Yes sir, there are two secrets that must be added to the repository!
It's already a little late here, so I'll get them to you early tomorrow if that's okay 🙂 |
Hey 👋
Summary
This PR is part of a push to get neovim plugins on luarocks.org.
See also:
With luarocks/rocks.nvim, it is the plugin authors' responsibility to declare dependencies - not the user's.
Installing this plugin becomes as simple as
:Rocks install telescope-zf-native.nvim
.Things done:
The workflows are based on this guide
Notes:
Important
master
(if this lands onmaster
), therelease-please
workflow creates (or updates an existing) release PR.Doing so will result in a SemVer tag, a changelog update, and a GitHub release, which will trigger the
luarocks
workflow.If you would like versioning to start from a specific version (e.g. 2.0.0), you can configure this with a manifest.
neovim
and/orvim
labels have to be added to the luarocks package manually (after the first upload), for this plugin to show up in https://luarocks.org/labels/neovim or https://luarocks.org/labels/vim, respectively.