Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPEC: put Slurm version in RPM release #52

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Conversation

kcgthb
Copy link
Contributor

@kcgthb kcgthb commented May 14, 2021

Add the Slurm version the RPM has been compiled with in the package name.

The main motivation is to be able to tell from the RPM version which version of Slurm the DRMAA package was built against, and facilitate upgrades when the plugin must be rebuilt for newer Slurm versions.

Copy link
Owner

@natefoo natefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went around in circles when adding the spec trying to figure out the best way to do this. I think this won't force reinstallation when you change Slurm versions but it would at least make it more obvious what's going on to the admin?

@kcgthb
Copy link
Contributor Author

kcgthb commented Sep 2, 2021

Yes, that won't force reinstallation when the Slurm version is upgraded (and I can't think of a good way to create a dependency that would do this, esp. since only major Slurm versions matter), but that should make things more visible for the admin, that's the idea.
Thanks for approving the change!

@natefoo natefoo merged commit af2c2c1 into natefoo:main Oct 7, 2021
@natefoo
Copy link
Owner

natefoo commented Oct 7, 2021

Thanks @kcgthb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants