Discover and include mime type when attaching files. #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -322,13 +322,13 @@ function testParsingContentTypeUpload() | |||
|
|
|||
| function testAttach() { | |||
| $req = Request::init(); | |||
|
|
|||
| $req->attach(array('index' => '/dir/filename')); | |||
| $filename = 'test_image.jpg'; | |||
There was a problem hiding this comment.
Probably not a bad idea to have this be a fully quantified path to be safe. I believe if the test is run a la carte from another directory, it would break. Correct?
There was a problem hiding this comment.
Just updated the code to use a full path.
nategood
pushed a commit
that referenced
this pull request
Dec 19, 2014
Discover and include mime type when attaching files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attach()method so that the file mime type is sent on the request.finfo_open(FILEINFO_MIME_TYPE)and then doing afinfo_file()on each of the attached files.curl_file_create()function or with the regularcurl@.