Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #295, due to iterator-seq change #296

Merged
merged 7 commits into from
Jan 12, 2016
Merged

fix #295, due to iterator-seq change #296

merged 7 commits into from
Jan 12, 2016

Conversation

jiyouyou125
Copy link
Contributor

happy. ^_^

I changed cascalog-core/project.clj dep to [org.clojure/clojure "1.7.0"]
modify iterator-seq to iter-seq.

it works. mutli-results:
user=> multi-results
((["ben" 35]) (["ben" 35] ["jerry" 41]))

I don't know another iterator-seq(tap.clj/pluck-tuple) weather has the same bug.

but it fix ??-

@jiyouyou125
Copy link
Contributor Author

also change pluck-tuple, fix overflow when ci build.

@jiyouyou125
Copy link
Contributor Author

add profile for clojure 1.6,1.7

@@ -6,6 +6,10 @@ language: clojure
lein: lein2
script: JVM_OPTS="-Djava.library.path=$PWD/hadoop-lzo-native/lib" lein2 sub with-profile dev,provided test
before_install:
- cat /etc/hosts # optionally check the content *before*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the story with this stuff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis-ci/travis-ci#5227 (comment)
Buffer overflow in Java_java_net_Inet4AddressImpl_getLocalHostName of OpenJDK6 and OpenJDK 7

@sritchie
Copy link
Collaborator

Thanks, this is great! Just a couple of comments.

1 similar comment
@sritchie
Copy link
Collaborator

Thanks, this is great! Just a couple of comments.

@jiyouyou125
Copy link
Contributor Author

@sritchie Thanks very much for your advice.
already fixed parallel type, added type hint to iter-seq.

sritchie added a commit that referenced this pull request Jan 12, 2016
fix #295, due to iterator-seq change
@sritchie sritchie merged commit 08db2e9 into nathanmarz:develop Jan 12, 2016
@sritchie
Copy link
Collaborator

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants