Fix missing page parameter in 'update:frompage' and 'update:topage' e…

…vents (Closes #125). Rename 'update-on-keyup' prop to 'update-on-input-keyup'.
nathanreyes · Apr 12, 2018 · 9e97e86 · 9e97e86
1 parent e7b0f1c
commit 9e97e86
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # v0.9.3
 ## Bug Fixes
+### `v-calendar`
+* Fix bug where initial `update:frompage` and `update:topage` events missing page argument. Closes #125.
+
 ### `v-date-picker`
 * Fix bug where `formats` prop not getting forwarded to `v-calendar`. Closes #123.
 
@@ -9,7 +12,7 @@
 
 ## Improvements
 ### `v-date-picker`
-* Added `update-on-keyup` prop to update picker selection on every `keyup` event.
+* Added `update-on-input-keyup` prop to update picker selection on every `keyup` event.
 * Custom slot method `updateValue` can now accept options as the second parameter. Closes #118.
 
 | Property | Description | Default Value |

diff --git a/src/components/CalendarPane.vue b/src/components/CalendarPane.vue
@@ -286,7 +286,7 @@ export default {
       this.page_ = this.loadPage(this.page);
     } else {
       this.page_ = this.loadPage(todayComps);
-      this.$emit('update:page');
+      this.$emit('update:page', this.page_);
     }
     this.preloadPages();
   },

diff --git a/src/components/DatePicker.vue b/src/components/DatePicker.vue
@@ -113,9 +113,9 @@ export default {
     availableDates: null,
     formats: Object, // Resolved by computed property
     inputProps: { type: Object, default: () => ({}) }, // Resolved by computed property
-    updateOnKeyup: {
+    updateOnInputKeyup: {
       type: Boolean,
-      default: () => defaults.datePickerUpdateOnKeyup,
+      default: () => defaults.datePickerUpdateOnInputKeyup,
     },
     tintColor: { type: String, default: () => defaults.datePickerTintColor },
     dragAttribute: Object, // Resolved by computed property
@@ -422,7 +422,7 @@ export default {
       });
     },
     inputKeyup(e) {
-      if (e.keyCode !== 13 && this.updateOnKeyup) {
+      if (e.keyCode !== 13 && this.updateOnInputKeyup) {
         this.updateValue(this.inputValue, {
           formatInput: false,
           hidePopover: false,

diff --git a/src/utils/defaults.js b/src/utils/defaults.js
@@ -41,7 +41,7 @@ const defaults = {
       placeholder: `${format} - ${format}`,
     }),
   }),
-  datePickerUpdateOnKeyup: true,
+  datePickerUpdateOnInputKeyup: true,
   datePickerTintColor: '#66B3CC',
   datePickerShowCaps: false,
   datePickerShowDayPopover: true,