Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vue.min.js included in component? #23

Closed
LucaRainone opened this issue Dec 13, 2017 · 1 comment
Closed

vue.min.js included in component? #23

LucaRainone opened this issue Dec 13, 2017 · 1 comment
Assignees
@nathanreyes
Labels
bug

Comments

@LucaRainone
Copy link
Contributor

It seems that build script include the whole vue library in an encapsulated scope (not available outside the component).
We can see too in CDN https://unpkg.com/[email protected]/lib/v-calendar.min.js with the copyright.

Is it really needed? There is a way to have only the component?
@LucaRainone LucaRainone mentioned this issue Dec 13, 2017
Merged
@nathanreyes
Copy link
Owner

Wow that is quite embarrassing. Thank you for the input.

@nathanreyes nathanreyes self-assigned this Dec 13, 2017
LucaRainone pushed a commit to LucaRainone/v-calendar that referenced this issue Dec 14, 2017
@LucaRainone
Removes Vue scope dependency. Closes nathanreyes#23
099a053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanreyes nathanreyes

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LucaRainone @nathanreyes