Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutdown Dependencies #1038

Closed
wants to merge 5 commits into from
Closed

Conversation

heywhy
Copy link
Contributor

@heywhy heywhy commented Apr 12, 2023

  • reduce dependencies to only @vue/runtime-core
  • improve nativescript.webpack.js
  • update the blank template with necessary dependencies
  • make the blank template work with vscode vue extension by patching tsconfig
  • [navigation] dispose page native view before unmounting component
  • update demo app to a working condition

Misc

I will prefer that the vue team allows one to set the vue library to use for template compilation so that one can do the below:

"vueCompilerOptions" {
  "target": 3,
  "vueLibrary": "nativescript-vue"
}

Or they return @vue/runtime-core in this function instead of vue.

@vallemar
Copy link
Contributor

vallemar commented Apr 12, 2023

@heywhy would it be ok to return in this line vnode so that everyone has el or the instance of vue?? https://github.com/nativescript-vue/nativescript-vue/pull/1038/files#diff-92b6f52e2c1b302cd9d15133831c595f151215aa1dfda274ff29fbd33d89a9b2R37

@heywhy
Copy link
Contributor Author

heywhy commented Apr 12, 2023

@heywhy would it be ok to return in this line vnode so that everyone has el?? https://github.com/nativescript-vue/nativescript-vue/pull/1038/files#diff-92b6f52e2c1b302cd9d15133831c595f151215aa1dfda274ff29fbd33d89a9b2R37

Yes, it is ok. I didn't do it that way because I couldn't think of a use case for it. Thinking of your comments here, I don't know if I should close the first PR so as to reduce context switching. 😅

@heywhy
Copy link
Contributor Author

heywhy commented Apr 14, 2023

I've created a PR on the vue-loader project (vuejs/vue-loader#2038), hopefully this gets merged before the conclusion of this PR so I can take off the module resolution patch.

@rigor789 rigor789 mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants