Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow connecting to account servers without TLS #83

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Allow connecting to account servers without TLS #83

merged 1 commit into from
Sep 13, 2022

Conversation

nsurfer
Copy link
Contributor

@nsurfer nsurfer commented Sep 13, 2022

Currently, we only read the server URLs in an Account CRD if TLS is configured. This change makes it so that we always read the account server URLs.

It should allow something like this to work.

---
apiVersion: jetstream.nats.io/v1beta2
kind: Account
metadata:
  name: a-app
spec:
  name: a-app
  servers:
  - nats://a-app.test.tech:@nats.default.svc

@nsurfer nsurfer changed the title Allow connecting to servers without TLS Allow connecting to account servers without TLS Sep 13, 2022
wallyqs
wallyqs approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wallyqs wallyqs merged commit 9bd30e9 into main Sep 13, 2022
@nsurfer nsurfer deleted the fix-no-servers branch September 13, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsurfer @wallyqs