Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support https monitoring #131

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Support https monitoring #131

merged 2 commits into from
Feb 25, 2019

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Feb 24, 2019

Enables monitoring and liveness check using https for the monitoring endpoint:

apiVersion: "nats.io/v1alpha2"
kind: "NatsCluster"
metadata:
  name: "nats-cluster"
spec:
  # Number of nodes in the cluster
  size: 3
  version: "1.4.0"

  tls:
    enableHttps: true
    serverSecret: "nats-clients-tls"

Fixes #128

@wallyqs
Support https monitoring
8e342d6 
Signed-off-by: Waldemar Quevedo <[email protected]>
@wallyqs
Add test for monitoring https
1b73277 
Signed-off-by: Waldemar Quevedo <[email protected]>
@wallyqs wallyqs merged commit 1b73277 into nats-io:release/v0.4.2 Feb 25, 2019
ColinSullivan1
ColinSullivan1 reviewed Feb 25, 2019
View reviewed changes
Copy link
Member

@ColinSullivan1 ColinSullivan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wallyqs wallyqs mentioned this pull request Feb 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinSullivan1 ColinSullivan1 ColinSullivan1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wallyqs @ColinSullivan1