WIP: allow for changing the namespace where operator runs #167
Conversation
Changes:
1. Changed KubernetesNamespaceNatsIO to a var.
2. This will allow a compile time override of nats namespace
for advanced k8s admins to configure a non nats-io namespace for
cluster scoped deployment.
3. Enables workflows referred by nats-io#126
supriya-premkumar
force-pushed
the
nats-ns
branch
from
e5897b0
to
7a85506
Compare
|
@supriya-premkumar thank you for this contribution. Following #126, would you be open to work with me to evolve this PR into something that doesn't depend on having users building their own images? |
Hi @pires I would be happy to help with this. Could you please give me pointers on where I can get started and Thank you for your time on this. |
|
Can I find you on NATS slack, @supriya-premkumar? Ping me @pires! Thanks a lot. |
pires
changed the title
|
why isn't it merged? i'm very interested for this feature. |
|
The limitation here is that this requires users to build their own binaries/container images. I also think this would not work as expected given https://github.com/nats-io/nats-operator/blob/master/cmd/operator/main.go#L108-L112 |
Changes:
non nats-io namespace for cluster scoped deployment.