Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use less replicas on upgrade test #178

Merged
merged 3 commits into from
Apr 29, 2019
Merged

Use less replicas on upgrade test #178

merged 3 commits into from
Apr 29, 2019

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Apr 27, 2019

It has been failing a couple of times with timeouts.
Signed-off-by: Waldemar Quevedo [email protected]

Signed-off-by: Waldemar Quevedo <[email protected]>
Signed-off-by: Waldemar Quevedo <[email protected]>
@pires
Copy link
Collaborator

pires commented Apr 27, 2019

Well, maybe we could investigate why it is timing out?

@wallyqs
Copy link
Member Author

wallyqs commented Apr 27, 2019

@pires anyway to bubble up those errors from the skaffold run?

@wallyqs
Copy link
Member Author

wallyqs commented Apr 27, 2019

It is usually the last test and failing on waiting for the cluster to come up, and since not failing locally guess it might be due to temp lack of resources on the Travis minikube. We may have some instances being tore down async in between tests that could cause that which could be another thing to look at.

@wallyqs
Copy link
Member Author

wallyqs commented Apr 28, 2019

Locally can make it fail when the test suite takes longer than 10m, so we could extend the go test timeout to 20m for example and try to improve the length of some of the tests (always using the same set of nats server images so that they are cached for example).

@pires
Copy link
Collaborator

pires commented Apr 29, 2019

OK this will maybe suffice for now.

Are we not using the official container images? Also, container images are cached per Kubernetes node alone.

@pires pires merged commit 8abc9f2 into master Apr 29, 2019
@pires pires deleted the upgrade-cluster-test branch April 29, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants