Enable specifing a ClientsAuthFile for user authorization data
#179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pires
requested changes
Apr 29, 2019
This commit adds support from reading the authorization section of the gnatsd config from a JSON file located within the nats-operator container. This allows secrets the data to be placed on disk using sidecars like consul-template. Depends on nats-io#171
Signed-off-by: Waldemar Quevedo <[email protected]>
Signed-off-by: Waldemar Quevedo <[email protected]>
Signed-off-by: Waldemar Quevedo <[email protected]>
Signed-off-by: Waldemar Quevedo <[email protected]>
Signed-off-by: Waldemar Quevedo <[email protected]>
pires
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #159
Includes a few fixes and also extends the tests timeout to 20m since with the tests added in this branch now
go testtakes over 10m which makes the test build fail. /cc @schancel