Fixed a bug that could lead to perceived message loss under JetStream. #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under load and pressure from concurrent publishing and consuming with multiple consumers the filestore would return a partial or no cache error to the upper layers. For consumers this could result in us skipping a stream sequence when we should not. This change stabilizes the filestore and removes the flush state for msg blocks. I also found some bugs that did not track last sequence properly after snapshots / restore. Signed-off-by: Derek Collison <[email protected]>
|
Looks like this bug #2488 is related to your fixes. |
|
Unclear if they are related tbh. |
Not sure if it helps but my JetStream was having the same issues described in #2488 and once I switched from file storage to memory storage it improved a lot and no issues until now. |
kozlovic
requested changes
Sep 7, 2021
Signed-off-by: Derek Collison <[email protected]>
derekcollison
force-pushed
the
fs-stable
branch
from
e346b1b
to
2b2c4ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under load and pressure from concurrent publishing and consuming with multiple consumers the filestore would return a partial or no cache error to the upper layers. For consumers this could result in us skipping a stream sequence when we should not.
This change stabilizes the filestore and removes the flush state for msg blocks. I also found some bugs that did not track last sequence properly after snapshots / restore.
Also increased timeout under Travis for the Go tests. We were bumping up against the 10m default.
Signed-off-by: Derek Collison [email protected]
/cc @nats-io/core