Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADDED] Add support for multi-get directly from a stream. #5107

Merged
merged 3 commits into from
Feb 27, 2024
Merged

[ADDED] Add support for multi-get directly from a stream. #5107

merged 3 commits into from
Feb 27, 2024

Commits on Feb 27, 2024

  1. Add support for multi-get directly from a stream. 

    This allows a client to get multiple results based on multiple filters, each which can include a wildcard.
You can optionally specify and UpToSeq or UpToTime.

The results will be returned in sequential order.

They will have headers matching direct get batch as well, with num pending being how many more results are coming.
Currently we limit to 64 results maximum, and may revisit this in the future.

Signed-off-by: Derek Collison <[email protected]>
    @derekcollison
    derekcollison committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    c1bc696 View commit details
    Browse the repository at this point in the history

  2. Updated logic to mirror direct get batch and always send EOB. 

    Also made sure to honor MaxBytes and Batch same as direct get batch.

Left this here for easier comparison but will squash when merging.

Signed-off-by: Derek Collison <[email protected]>
    @derekcollison
    derekcollison committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    58a5834 View commit details
    Browse the repository at this point in the history

  3. Added in UpToSequence in EOB for Multi to allow proper paging with sa… 

    …me UpToSeq even if it was not set on original request.

Also removed need for Seq to be set on simple multi-requests.

Signed-off-by: Derek Collison <[email protected]>
    @derekcollison
    derekcollison committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    5eb4be4 View commit details
    Browse the repository at this point in the history