Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CI only} Use pull_request_target instead of pull_request #767

Closed
wants to merge 1 commit into from

Conversation

levb
Copy link
Collaborator

@levb levb commented Jun 21, 2024

We are having an issue running coverage upload from forked repo PRs. This should solve it, I think.

Testing for now from my own fork.

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick look at this event seems to show that there may be some security risks. So unless you perfectly understand the context and are positive that this does not apply, I would not make this change: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target (look for the Warning section and following link).

@levb
Copy link
Collaborator Author

levb commented Jun 21, 2024

@kozlovic I am still experimenting with this one

@kozlovic
Copy link
Member

@levb Sorry, I thought that I was asked to review, my mistake.

@levb
Copy link
Collaborator Author

levb commented Jun 21, 2024

I am just going to take codecov out of the forked repo PR flow for now. It appears that the codecov people are working on the issue, and there is a workaround but it's kludgy. Will close this PR and open another one to remove codecov from fork PRs for now

@levb levb closed this Jun 21, 2024
@levb levb deleted the lev-on-pr-target branch July 28, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants