Add Respond() #472
Merged
Add Respond() #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow a user to respond to a subscription callback that has not closed over a connection by referencing the request message.
func cb(m *nats.Msg) {
m.Respond([]byte("I am here")
}
kozlovic
approved these changes
May 25, 2019
| t.Fatal("Failed to subscribe: ", err) | ||
| } | ||
|
|
||
| // Fake the bound notion by assigning Sub directly to test no reply. |
There was a problem hiding this comment.
I would have simply created a sync sub on another subject, publish a message (not request) to that subject, get the message, then call respond. No need to fake it.
There was a problem hiding this comment.
Its public so easy to do, but if you feel strongly I could make legit here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow a user to respond to a subscription callback that has not closed over a connection by referencing the request message.